Discussion:
error shutting down
Rob Audenaerde
2018-10-12 09:32:06 UTC
Permalink
Hi all,

I'm experiencing some jetty-shutdown problems after upgrading from 7.9 to
8.1. See the stacktrace below.

Is there a simple remedy for this? (or a known cause?) It is annoying
because this error prevents Jetty from shutting down, and I use this in my
tests, so my tests never end... :(

Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112


2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
at java.base/java.lang.Thread.run(Thread.java:844)
Martin Grigorov
2018-10-12 10:20:20 UTC
Permalink
Hi,

When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
)
There it will interrupt the page saving thread and it should stop:
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325

I do not remember changes in this area of the code in 8.x but it is not
impossible.
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after upgrading from 7.9 to
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is annoying
because this error prevents Jetty from shutting down, and I use this in my
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
at java.base/java.lang.Thread.run(Thread.java:844)
Maxim Solodovnik
2018-10-12 13:30:52 UTC
Permalink
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time on this next week
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
)
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
I do not remember changes in this area of the code in 8.x but it is not
impossible.
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after upgrading from 7.9 to
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is annoying
because this error prevents Jetty from shutting down, and I use this in my
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax

---------------------------------------------------------------------
To unsubscribe, e-mail: users-***@wicket.apache.org
For additional commands, e-mail: users-***@wicket.apache.org
Rob Audenaerde
2018-10-12 14:08:25 UTC
Permalink
Is there a simple way to disable the AsynchronousDataStore (for now)?
Post by Maxim Solodovnik
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time on this next week
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
Post by Martin Grigorov
)
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
Post by Martin Grigorov
I do not remember changes in this area of the code in 8.x but it is not
impossible.
On Fri, Oct 12, 2018 at 12:32 PM Rob Audenaerde <
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after upgrading from 7.9
to
Post by Martin Grigorov
Post by Rob Audenaerde
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is annoying
because this error prevents Jetty from shutting down, and I use this
in my
Post by Martin Grigorov
Post by Rob Audenaerde
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
Post by Martin Grigorov
Post by Rob Audenaerde
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
Rob Audenaerde
2018-10-12 14:59:05 UTC
Permalink
BTW: I currently worked around it by (very ugly) adding a
Thread.sleep(1000) between the last test-action in Wicket and the
Jetty-shutdown. So it seems a timing issue (which probably explains why
Maxim has been seeing Jenkins failing occasionally).

Thanks for checking into this!

-Rob
Post by Rob Audenaerde
Is there a simple way to disable the AsynchronousDataStore (for now)?
Post by Maxim Solodovnik
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time on this next week
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
Post by Martin Grigorov
)
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
Post by Martin Grigorov
I do not remember changes in this area of the code in 8.x but it is not
impossible.
On Fri, Oct 12, 2018 at 12:32 PM Rob Audenaerde <
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after upgrading from
7.9 to
Post by Martin Grigorov
Post by Rob Audenaerde
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is annoying
because this error prevents Jetty from shutting down, and I use this
in my
Post by Martin Grigorov
Post by Rob Audenaerde
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
Post by Martin Grigorov
Post by Rob Audenaerde
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
Maxim Solodovnik
2018-10-24 07:52:34 UTC
Permalink
Here is the JIRA [1]

I was able to reproduce this issue running one of our tests in a bash loop
Original 8.2.0-SNAPSHOT usually hang on <10th iteration

After this [1] fix, it flawlessly works 201 iterations
I would appreciate if you can review/test these changes

[1] https://issues.apache.org/jira/browse/WICKET-6603
[2] https://github.com/apache/wicket/pull/300
Post by Rob Audenaerde
BTW: I currently worked around it by (very ugly) adding a
Thread.sleep(1000) between the last test-action in Wicket and the
Jetty-shutdown. So it seems a timing issue (which probably explains why
Maxim has been seeing Jenkins failing occasionally).
Thanks for checking into this!
-Rob
Post by Rob Audenaerde
Is there a simple way to disable the AsynchronousDataStore (for now)?
Post by Maxim Solodovnik
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time on this next week
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
)
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
I do not remember changes in this area of the code in 8.x but it is
not
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
impossible.
On Fri, Oct 12, 2018 at 12:32 PM Rob Audenaerde <
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after upgrading from
7.9 to
Post by Martin Grigorov
Post by Rob Audenaerde
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is
annoying
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
because this error prevents Jetty from shutting down, and I use this
in my
Post by Martin Grigorov
Post by Rob Audenaerde
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
--
WBR
Maxim aka solomax
Rob Audenaerde
2018-10-24 08:02:01 UTC
Permalink
Thank you Maxim!

I'd gladly test this.
Is there an standard/easy (maven?) way to test this in my application?

-Rob
Post by Maxim Solodovnik
Here is the JIRA [1]
I was able to reproduce this issue running one of our tests in a bash loop
Original 8.2.0-SNAPSHOT usually hang on <10th iteration
After this [1] fix, it flawlessly works 201 iterations
I would appreciate if you can review/test these changes
[1] https://issues.apache.org/jira/browse/WICKET-6603
[2] https://github.com/apache/wicket/pull/300
Post by Rob Audenaerde
BTW: I currently worked around it by (very ugly) adding a
Thread.sleep(1000) between the last test-action in Wicket and the
Jetty-shutdown. So it seems a timing issue (which probably explains why
Maxim has been seeing Jenkins failing occasionally).
Thanks for checking into this!
-Rob
Post by Rob Audenaerde
Is there a simple way to disable the AsynchronousDataStore (for now)?
Post by Maxim Solodovnik
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time on this next week
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
)
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
I do not remember changes in this area of the code in 8.x but it is
not
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
impossible.
On Fri, Oct 12, 2018 at 12:32 PM Rob Audenaerde <
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after upgrading from
7.9 to
Post by Martin Grigorov
Post by Rob Audenaerde
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is
annoying
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
because this error prevents Jetty from shutting down, and I use
this
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
in my
Post by Martin Grigorov
Post by Rob Audenaerde
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
--
WBR
Maxim aka solomax
Maxim Solodovnik
2018-10-24 08:07:44 UTC
Permalink
My steps were:

0) locate problem test (TestInstall in my case)
1) build updated wicket-core
2) Run problem test in a loop:
reset && for i in `seq 0 200`; do echo; echo; echo "--------------- ${i}
-----------------"; echo; echo; echo; mvn clean test
-DgenerateReports=false -Dtest=TestInstall -o; done

We also can merge this code (after proper review)
And then it can be tested using Jenkins and 8.2.0-SNAPSHOT as wicket version
Post by Rob Audenaerde
Thank you Maxim!
I'd gladly test this.
Is there an standard/easy (maven?) way to test this in my application?
-Rob
Post by Maxim Solodovnik
Here is the JIRA [1]
I was able to reproduce this issue running one of our tests in a bash
loop
Post by Maxim Solodovnik
Original 8.2.0-SNAPSHOT usually hang on <10th iteration
After this [1] fix, it flawlessly works 201 iterations
I would appreciate if you can review/test these changes
[1] https://issues.apache.org/jira/browse/WICKET-6603
[2] https://github.com/apache/wicket/pull/300
Post by Rob Audenaerde
BTW: I currently worked around it by (very ugly) adding a
Thread.sleep(1000) between the last test-action in Wicket and the
Jetty-shutdown. So it seems a timing issue (which probably explains why
Maxim has been seeing Jenkins failing occasionally).
Thanks for checking into this!
-Rob
On Fri, Oct 12, 2018 at 4:08 PM Rob Audenaerde <
Post by Rob Audenaerde
Is there a simple way to disable the AsynchronousDataStore (for now)?
On Fri, Oct 12, 2018 at 3:31 PM Maxim Solodovnik <
Post by Maxim Solodovnik
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time on
this
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
next week
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
)
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
I do not remember changes in this area of the code in 8.x but it
is
Post by Maxim Solodovnik
Post by Rob Audenaerde
not
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
impossible.
On Fri, Oct 12, 2018 at 12:32 PM Rob Audenaerde <
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after upgrading
from
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
7.9 to
Post by Martin Grigorov
Post by Rob Audenaerde
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is
annoying
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
because this error prevents Jetty from shutting down, and I use
this
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
in my
Post by Martin Grigorov
Post by Rob Audenaerde
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
Post by Maxim Solodovnik
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
Maxim Solodovnik
2018-10-24 08:09:01 UTC
Permalink
BTW master branch of our project is already uses wicket 8.2.0-SNAPSHOT
Post by Maxim Solodovnik
0) locate problem test (TestInstall in my case)
1) build updated wicket-core
reset && for i in `seq 0 200`; do echo; echo; echo "--------------- ${i}
-----------------"; echo; echo; echo; mvn clean test
-DgenerateReports=false -Dtest=TestInstall -o; done
We also can merge this code (after proper review)
And then it can be tested using Jenkins and 8.2.0-SNAPSHOT as wicket version
Post by Rob Audenaerde
Thank you Maxim!
I'd gladly test this.
Is there an standard/easy (maven?) way to test this in my application?
-Rob
Post by Maxim Solodovnik
Here is the JIRA [1]
I was able to reproduce this issue running one of our tests in a bash
loop
Post by Maxim Solodovnik
Original 8.2.0-SNAPSHOT usually hang on <10th iteration
After this [1] fix, it flawlessly works 201 iterations
I would appreciate if you can review/test these changes
[1] https://issues.apache.org/jira/browse/WICKET-6603
[2] https://github.com/apache/wicket/pull/300
Post by Rob Audenaerde
BTW: I currently worked around it by (very ugly) adding a
Thread.sleep(1000) between the last test-action in Wicket and the
Jetty-shutdown. So it seems a timing issue (which probably explains
why
Post by Maxim Solodovnik
Post by Rob Audenaerde
Maxim has been seeing Jenkins failing occasionally).
Thanks for checking into this!
-Rob
On Fri, Oct 12, 2018 at 4:08 PM Rob Audenaerde <
Post by Rob Audenaerde
Is there a simple way to disable the AsynchronousDataStore (for
now)?
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
On Fri, Oct 12, 2018 at 3:31 PM Maxim Solodovnik <
Post by Maxim Solodovnik
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time on
this
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
next week
On Fri, 12 Oct 2018 at 17:20, Martin Grigorov <
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
)
There it will interrupt the page saving thread and it should
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
I do not remember changes in this area of the code in 8.x but it
is
Post by Maxim Solodovnik
Post by Rob Audenaerde
not
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
impossible.
On Fri, Oct 12, 2018 at 12:32 PM Rob Audenaerde <
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after upgrading
from
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
7.9 to
Post by Martin Grigorov
Post by Rob Audenaerde
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is
annoying
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
because this error prevents Jetty from shutting down, and I use
this
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
in my
Post by Martin Grigorov
Post by Rob Audenaerde
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
Post by Maxim Solodovnik
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
Maxim Solodovnik
2018-10-26 15:58:33 UTC
Permalink
Hello Rob,

The PR was merged, so you can verify the fix using 8.2.0-SNAPSHOT (in ~30
minutes or so ) :))
Post by Maxim Solodovnik
BTW master branch of our project is already uses wicket 8.2.0-SNAPSHOT
Post by Maxim Solodovnik
0) locate problem test (TestInstall in my case)
1) build updated wicket-core
reset && for i in `seq 0 200`; do echo; echo; echo "--------------- ${i}
-----------------"; echo; echo; echo; mvn clean test
-DgenerateReports=false -Dtest=TestInstall -o; done
We also can merge this code (after proper review)
And then it can be tested using Jenkins and 8.2.0-SNAPSHOT as wicket version
Post by Rob Audenaerde
Thank you Maxim!
I'd gladly test this.
Is there an standard/easy (maven?) way to test this in my application?
-Rob
Post by Maxim Solodovnik
Here is the JIRA [1]
I was able to reproduce this issue running one of our tests in a bash
loop
Post by Maxim Solodovnik
Original 8.2.0-SNAPSHOT usually hang on <10th iteration
After this [1] fix, it flawlessly works 201 iterations
I would appreciate if you can review/test these changes
[1] https://issues.apache.org/jira/browse/WICKET-6603
[2] https://github.com/apache/wicket/pull/300
Post by Rob Audenaerde
BTW: I currently worked around it by (very ugly) adding a
Thread.sleep(1000) between the last test-action in Wicket and the
Jetty-shutdown. So it seems a timing issue (which probably explains
why
Post by Maxim Solodovnik
Post by Rob Audenaerde
Maxim has been seeing Jenkins failing occasionally).
Thanks for checking into this!
-Rob
On Fri, Oct 12, 2018 at 4:08 PM Rob Audenaerde <
Post by Rob Audenaerde
Is there a simple way to disable the AsynchronousDataStore (for
now)?
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
On Fri, Oct 12, 2018 at 3:31 PM Maxim Solodovnik <
Post by Maxim Solodovnik
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time on
this
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
next week
On Fri, 12 Oct 2018 at 17:20, Martin Grigorov <
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
)
There it will interrupt the page saving thread and it should
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
I do not remember changes in this area of the code in 8.x but
it is
Post by Maxim Solodovnik
Post by Rob Audenaerde
not
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
impossible.
On Fri, Oct 12, 2018 at 12:32 PM Rob Audenaerde <
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after upgrading
from
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
7.9 to
Post by Martin Grigorov
Post by Rob Audenaerde
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is
annoying
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
because this error prevents Jetty from shutting down, and I
use
Post by Maxim Solodovnik
this
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
in my
Post by Martin Grigorov
Post by Rob Audenaerde
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
Post by Maxim Solodovnik
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
Rob Audenaerde
2018-10-26 16:32:53 UTC
Permalink
Will do, but after the weekend :D
Post by Maxim Solodovnik
Hello Rob,
The PR was merged, so you can verify the fix using 8.2.0-SNAPSHOT (in ~30
minutes or so ) :))
Post by Maxim Solodovnik
BTW master branch of our project is already uses wicket 8.2.0-SNAPSHOT
Post by Maxim Solodovnik
0) locate problem test (TestInstall in my case)
1) build updated wicket-core
reset && for i in `seq 0 200`; do echo; echo; echo "--------------- ${i}
-----------------"; echo; echo; echo; mvn clean test
-DgenerateReports=false -Dtest=TestInstall -o; done
We also can merge this code (after proper review)
And then it can be tested using Jenkins and 8.2.0-SNAPSHOT as wicket version
Post by Rob Audenaerde
Thank you Maxim!
I'd gladly test this.
Is there an standard/easy (maven?) way to test this in my application?
-Rob
Post by Maxim Solodovnik
Here is the JIRA [1]
I was able to reproduce this issue running one of our tests in a bash
loop
Post by Maxim Solodovnik
Original 8.2.0-SNAPSHOT usually hang on <10th iteration
After this [1] fix, it flawlessly works 201 iterations
I would appreciate if you can review/test these changes
[1] https://issues.apache.org/jira/browse/WICKET-6603
[2] https://github.com/apache/wicket/pull/300
On Fri, 12 Oct 2018 at 21:59, Rob Audenaerde <
Post by Rob Audenaerde
BTW: I currently worked around it by (very ugly) adding a
Thread.sleep(1000) between the last test-action in Wicket and the
Jetty-shutdown. So it seems a timing issue (which probably explains
why
Post by Maxim Solodovnik
Post by Rob Audenaerde
Maxim has been seeing Jenkins failing occasionally).
Thanks for checking into this!
-Rob
On Fri, Oct 12, 2018 at 4:08 PM Rob Audenaerde <
Post by Rob Audenaerde
Is there a simple way to disable the AsynchronousDataStore (for
now)?
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
On Fri, Oct 12, 2018 at 3:31 PM Maxim Solodovnik <
Post by Maxim Solodovnik
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time on
this
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
next week
On Fri, 12 Oct 2018 at 17:20, Martin Grigorov <
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
)
There it will interrupt the page saving thread and it should
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
I do not remember changes in this area of the code in 8.x but
it is
Post by Maxim Solodovnik
Post by Rob Audenaerde
not
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
impossible.
On Fri, Oct 12, 2018 at 12:32 PM Rob Audenaerde <
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after
upgrading
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
from
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
7.9 to
Post by Martin Grigorov
Post by Rob Audenaerde
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It is
annoying
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
because this error prevents Jetty from shutting down, and I
use
Post by Maxim Solodovnik
this
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
in my
Post by Martin Grigorov
Post by Rob Audenaerde
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore -
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
Post by Maxim Solodovnik
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
Maxim Solodovnik
2018-10-26 16:50:50 UTC
Permalink
Please let as know if the issue is still reproducible :)
Post by Rob Audenaerde
Will do, but after the weekend :D
Post by Maxim Solodovnik
Hello Rob,
The PR was merged, so you can verify the fix using 8.2.0-SNAPSHOT (in ~30
minutes or so ) :))
Post by Maxim Solodovnik
BTW master branch of our project is already uses wicket 8.2.0-SNAPSHOT
Post by Maxim Solodovnik
0) locate problem test (TestInstall in my case)
1) build updated wicket-core
reset && for i in `seq 0 200`; do echo; echo; echo "---------------
${i}
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
-----------------"; echo; echo; echo; mvn clean test
-DgenerateReports=false -Dtest=TestInstall -o; done
We also can merge this code (after proper review)
And then it can be tested using Jenkins and 8.2.0-SNAPSHOT as wicket version
On Wed, 24 Oct 2018 at 15:02, Rob Audenaerde <
Post by Rob Audenaerde
Thank you Maxim!
I'd gladly test this.
Is there an standard/easy (maven?) way to test this in my
application?
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
-Rob
On Wed, Oct 24, 2018 at 9:52 AM Maxim Solodovnik <
Post by Maxim Solodovnik
Here is the JIRA [1]
I was able to reproduce this issue running one of our tests in a
bash
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
loop
Post by Maxim Solodovnik
Original 8.2.0-SNAPSHOT usually hang on <10th iteration
After this [1] fix, it flawlessly works 201 iterations
I would appreciate if you can review/test these changes
[1] https://issues.apache.org/jira/browse/WICKET-6603
[2] https://github.com/apache/wicket/pull/300
On Fri, 12 Oct 2018 at 21:59, Rob Audenaerde <
Post by Rob Audenaerde
BTW: I currently worked around it by (very ugly) adding a
Thread.sleep(1000) between the last test-action in Wicket and the
Jetty-shutdown. So it seems a timing issue (which probably
explains
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
why
Post by Maxim Solodovnik
Post by Rob Audenaerde
Maxim has been seeing Jenkins failing occasionally).
Thanks for checking into this!
-Rob
On Fri, Oct 12, 2018 at 4:08 PM Rob Audenaerde <
Post by Rob Audenaerde
Is there a simple way to disable the AsynchronousDataStore (for
now)?
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
On Fri, Oct 12, 2018 at 3:31 PM Maxim Solodovnik <
Post by Maxim Solodovnik
I'm occasionally able to see this error on Apache Jenkins, but
unfortunately there is no clear steps to reproduce
I was unable to find what is wrong, will spend some more time
on
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
this
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
next week
On Fri, 12 Oct 2018 at 17:20, Martin Grigorov <
Post by Martin Grigorov
Hi,
When the application stops Application#destroy() should call
AsynchronousDataStore#destroy() (
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L101
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
)
There it will interrupt the page saving thread and it should
https://github.com/apache/wicket/blob/6ee5313d405fbbdd4ce9d9a03ccb526358834fca/wicket-core/src/main/java/org/apache/wicket/pageStore/AsynchronousDataStore.java#L325
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
I do not remember changes in this area of the code in 8.x
but
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
it is
Post by Maxim Solodovnik
Post by Rob Audenaerde
not
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
impossible.
On Fri, Oct 12, 2018 at 12:32 PM Rob Audenaerde <
Post by Rob Audenaerde
Hi all,
I'm experiencing some jetty-shutdown problems after
upgrading
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
from
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
7.9 to
Post by Martin Grigorov
Post by Rob Audenaerde
8.1. See the stacktrace below.
Is there a simple remedy for this? (or a known cause?) It
is
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
annoying
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
because this error prevents Jetty from shutting down, and
I
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
use
Post by Maxim Solodovnik
this
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
in my
Post by Martin Grigorov
Post by Rob Audenaerde
tests, so my tests never end... :(
Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore
-
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
java.lang.InterruptedException
at
java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at
org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Rob Audenaerde
Post by Rob Audenaerde
Post by Maxim Solodovnik
Post by Martin Grigorov
Post by Rob Audenaerde
at java.base/java.lang.Thread.run(Thread.java:844)
--
WBR
Maxim aka solomax
---------------------------------------------------------------------
Post by Maxim Solodovnik
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
--
WBR
Maxim aka solomax
Loading...